Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Co #11206: Fix WASM block producer panic#5311

Closed
ggwpez wants to merge 8 commits intomasterfrom
oty-boxed-events
Closed

Co #11206: Fix WASM block producer panic#5311
ggwpez wants to merge 8 commits intomasterfrom
oty-boxed-events

Conversation

@ggwpez
Copy link
Copy Markdown
Member

@ggwpez ggwpez commented Apr 12, 2022

This is now just fixing a spelling mistake.
I think it makes sense to have this MR since the substrate companion would otherwise silently change the runtime.

Companion for paritytech/substrate#11206

ggwpez added 2 commits April 12, 2022 11:48
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez added A3-in_progress Pull request is in progress. No review needed at this stage. B7-runtimenoteworthy D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Apr 12, 2022
@ggwpez ggwpez self-assigned this Apr 12, 2022
@paritytech-ci paritytech-ci requested review from a team April 12, 2022 10:24
@github-actions github-actions bot added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Apr 12, 2022
@ggwpez ggwpez added A3-in_progress Pull request is in progress. No review needed at this stage. and removed A0-please_review Pull request needs code review. labels Apr 12, 2022
ggwpez added 6 commits April 13, 2022 11:11
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
This reverts commit e021a0f.
This reverts commit 29d8446.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez changed the title Co #11206: Boxed events Co #11206: Fix WASM block producer panic Apr 13, 2022
@ggwpez ggwpez added C7-high ❗️ A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. C7-high ❗️ labels Apr 13, 2022
@ggwpez ggwpez added the C1-low PR touches the given topic and has a low impact on builders. label Apr 13, 2022
@ggwpez
Copy link
Copy Markdown
Member Author

ggwpez commented Apr 13, 2022

Closing now since it is not needed anymore since Im using a simpler approach.
The spell mistake can be fixed in another dedicated MR for that I think.

@ggwpez ggwpez closed this Apr 13, 2022
@ggwpez ggwpez deleted the oty-boxed-events branch September 6, 2022 10:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants